Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: handle conflicting replaces in the workspace module #44698

Open
stamblerre opened this issue Feb 28, 2021 · 0 comments
Open

x/tools/gopls: handle conflicting replaces in the workspace module #44698

stamblerre opened this issue Feb 28, 2021 · 0 comments
Labels
gopls Tools
Projects
gopls on-deck
Milestone
gopls/on-deck

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Feb 28, 2021 •
edited

When the workspace module replaces 2+ different versions of the same dependency, we should prefer the highest version. We should also prefer file replaces to version replaces.

What should we do if there are multiple file replaces?
@stamblerre stamblerre added this to the gopls/workspace-module milestone Feb 28, 2021
@stamblerre stamblerre changed the title x/tools/gopls: prefer higher versions when encountering conflicts in workspace module x/tools/gopls: handle conflicting replaces in the workspace module Feb 28, 2021
@stamblerre stamblerre removed this from the gopls/workspace-module milestone Feb 28, 2021
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Feb 28, 2021
@stamblerre stamblerre added this to To Do in gopls on-deck Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Tools
Projects
gopls on-deck
To Do
Milestone
gopls/on-deck
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot