While testing for golang/vscode-go#1257, I noticed that the staticcheck offered from gopls includes ST1021 that's a non-default check in the standalone staticcheck tool. (I am using v0.6.6 gopls)
Since vscode-go is currently telling users to use staticcheck offered by gopls instead of using the lintOnSave feature when using staticcheck as the lint tool, I think it's desirable to respect the default offered by the standalone tool. Otherwise, we need to document the difference and why.
The text was updated successfully, but these errors were encountered:
stamblerre
changed the title
x/tools/gopls: respect the default checks of the staticcheck tool or document the difference
x/tools/gopls: respect the default checks of the staticcheck tooll
Mar 1, 2021
stamblerre
changed the title
x/tools/gopls: respect the default checks of the staticcheck tooll
x/tools/gopls: respect the default checks of the staticcheck tool
Mar 1, 2021
While testing for golang/vscode-go#1257, I noticed that the staticcheck offered from gopls includes ST1021 that's a non-default check in the standalone staticcheck tool. (I am using v0.6.6 gopls)
Since vscode-go is currently telling users to use staticcheck offered by gopls instead of using the lintOnSave feature when using
staticcheck
as the lint tool, I think it's desirable to respect the default offered by the standalone tool. Otherwise, we need to document the difference and why.The text was updated successfully, but these errors were encountered: