Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: respect the default checks of the staticcheck tool #44712

Open
hyangah opened this issue Mar 1, 2021 · 0 comments
Open

x/tools/gopls: respect the default checks of the staticcheck tool #44712

hyangah opened this issue Mar 1, 2021 · 0 comments

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Mar 1, 2021

While testing for golang/vscode-go#1257, I noticed that the staticcheck offered from gopls includes ST1021 that's a non-default check in the standalone staticcheck tool. (I am using v0.6.6 gopls)

Since vscode-go is currently telling users to use staticcheck offered by gopls instead of using the lintOnSave feature when using staticcheck as the lint tool, I think it's desirable to respect the default offered by the standalone tool. Otherwise, we need to document the difference and why.

@gopherbot gopherbot added this to the Unreleased milestone Mar 1, 2021
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Mar 1, 2021
@stamblerre stamblerre changed the title x/tools/gopls: respect the default checks of the staticcheck tool or document the difference x/tools/gopls: respect the default checks of the staticcheck tooll Mar 1, 2021
@stamblerre stamblerre changed the title x/tools/gopls: respect the default checks of the staticcheck tooll x/tools/gopls: respect the default checks of the staticcheck tool Mar 1, 2021
@stamblerre stamblerre added this to To Do in gopls: v1.0.0 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants