Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: error position paths are relative to Config.Dir, should be absolute #44716

Open
heschi opened this issue Mar 1, 2021 · 0 comments

Comments

@heschi
Copy link
Contributor

@heschi heschi commented Mar 1, 2021

The go command reports errors relative to its working directory. go/packages passes them on as packages.Errors, e.g. in https://github.com/golang/tools/blob/7a079fcd7976efee71404a62f2b2be0bbc34f3a5/go/packages/golist.go#L706.

In packages.Package, all paths are absolute, so it's surprising to get relative paths in the errors. I think they should be absolute too.

@matloob

@dmitshur dmitshur changed the title go/packages: error position paths are relative to Config.Dir, should be absolute x/tools/go/packages: error position paths are relative to Config.Dir, should be absolute Mar 2, 2021
@gopherbot gopherbot added the Tools label Mar 2, 2021
@gopherbot gopherbot added this to the Unreleased milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants