Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: mark test dependencies in go.mod and go list -m #44743

Open
DeedleFake opened this issue Mar 2, 2021 · 1 comment
Open

proposal: mark test dependencies in go.mod and go list -m #44743

DeedleFake opened this issue Mar 2, 2021 · 1 comment

Comments

@DeedleFake
Copy link

@DeedleFake DeedleFake commented Mar 2, 2021

There have been a number of requests for a test dependencies section in go.mod. These requests actually don't make sense with the way that go.mod works, because it's really just a list of rules to follow for resolving dependencies, not a list of dependencies. The actual list of dependencies is per-package, not per-module, and is determined by the actual import statements in the code itself. The go tool, however, does add some extra information to the go.mod file in the form of an // indirect comment after dependencies that are only depended on by a dependency.

I propose adding an alternate comment flag, test, to indicate that a dependency is only required by tests. Along with this, add an indication of this to the Module struct used for formatting go list -m output.

@gopherbot gopherbot added this to the Proposal milestone Mar 2, 2021
@ianlancetaylor ianlancetaylor added this to Incoming in Proposals Mar 2, 2021
@komuw
Copy link
Contributor

@komuw komuw commented Mar 3, 2021

I tried implementing this sometime back as a cli at; https://github.com/komuw/ote (has bugs).

I would be in favor of the go tool adding // test comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Proposals
Incoming
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants