Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: ResolveTCPAddr used to accept net == ""; now doesn't #4476

Closed
bradfitz opened this issue Dec 1, 2012 · 2 comments

Comments

Projects
None yet
4 participants
@bradfitz
Copy link
Member

commented Dec 1, 2012

The github.com/ziutek/mymysql driver calls net.ResolveTCPAddr with an empty string for
the network.

In Go 1.0, that worked.

In Go tip, that returns net.UnkownNetworkError("")

I just wasted time debugging this when I recompiled Camlistore, which happens to use
ziutek/mymysql.  I didn't get a nice UnkownNetworkError, either, since it had been eaten
by other errors.

For Go 1 compatibility reasons, should we special-case "" in ResolveTCPAddr to
mean "tcp"?  I would like to.
@mikioh

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2012

Comment 1:

I'm fine with handling "" as a wildcard to net.ResolveProtocolAddr on internet 
protocol family address structs, not only TCP but UDP and IP, because so far 
the network string on ResolveProtocolAddr is just a hint for name resolvers.
@mikioh

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2012

Comment 2:

This issue was closed by revision e3e885b.

Status changed to Fixed.

@bradfitz bradfitz added fixed labels Dec 1, 2012

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015

@rsc rsc removed the go1.1 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.