Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link/internal/ld: TestWindowsIssue36495 fails on windows #44874

Closed
erifan opened this issue Mar 9, 2021 · 4 comments
Closed

cmd/link/internal/ld: TestWindowsIssue36495 fails on windows #44874

erifan opened this issue Mar 9, 2021 · 4 comments

Comments

@erifan
Copy link
Contributor

@erifan erifan commented Mar 9, 2021

Found this test failure from https://storage.googleapis.com/go-build-log/e16933d5/windows-amd64-2016_f006643d.log and https://storage.googleapis.com/go-build-log/e16933d5/windows-386-2008_32f17999.log, I'm sure it has nothing to do with the CL being tested.

@erifan erifan changed the title cmd/link/internal/ld: TestWindowsIssue36495 fails on windows/amd64 cmd/link/internal/ld: TestWindowsIssue36495 fails on windows Mar 9, 2021
@erifan
Copy link
Contributor Author

@erifan erifan commented Mar 9, 2021

The issue has been resolved by https://go-review.googlesource.com/c/go/+/299929

Loading

@erifan erifan closed this Mar 9, 2021
@tklauser
Copy link
Member

@tklauser tklauser commented Mar 9, 2021

Loading

@tklauser tklauser reopened this Mar 9, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 9, 2021

Change https://golang.org/cl/299990 mentions this issue: cmd/link/internal/ld: add missing close to deflake TestWindowsIssue36495

Loading

@tklauser
Copy link
Member

@tklauser tklauser commented Mar 9, 2021

I just hit this on https://golang.org/cl/299989 (based on latest master, with https://golang.org/cl/299929 in place), see https://storage.googleapis.com/go-build-log/041e4871/windows-amd64-2016_a33ebfaf.log

Sorry, I didn't realize https://golang.org/cl/299929 wasn't submitted yet when writing this.

Loading

@tklauser tklauser closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants