Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: Helper line number has changed in 1.16 [1.16 backport] #44888

Closed
gopherbot opened this issue Mar 9, 2021 · 3 comments
Closed

testing: Helper line number has changed in 1.16 [1.16 backport] #44888

gopherbot opened this issue Mar 9, 2021 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 9, 2021

@ianlancetaylor requested issue #44887 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport to 1.16

In some cases t.Helper seems to be ineffective. It's not critical but it's definitely annoying. We should fix it.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 19, 2021

Change https://golang.org/cl/303189 mentions this issue: [release-branch.go1.16] testing: update helperNames just before checking it

@toothrot
Copy link
Contributor

@toothrot toothrot commented Mar 24, 2021

Approved. There's no workaround and this regression makes t.Helper not very useful.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 24, 2021

Closed by merging 902d16e to release-branch.go1.16.

@gopherbot gopherbot closed this Mar 24, 2021
gopherbot pushed a commit that referenced this issue Mar 24, 2021
…ing it

parent's helperNames has not been set when frameSkip called, moving
helperNames initilazing to frameSkip.

For #44887
Fixes #44888

Change-Id: I5107c5951033e5e47d1ac441eac3ba5344a7bdc0
GitHub-Last-Rev: 44b90b2
GitHub-Pull-Request: #45071
Reviewed-on: https://go-review.googlesource.com/c/go/+/302469
Trust: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 6704843)
Reviewed-on: https://go-review.googlesource.com/c/go/+/303189
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants