Skip to content

testing: Helper line number has changed in 1.16 [1.16 backport] #44888

Closed
Closed
testing: Helper line number has changed in 1.16 [1.16 backport]#44888
Labels
CherryPickApprovedUsed during the release process for point releasesFrozenDueToAge
Milestone
Go1.16.3

Description

@gopherbot
gopherbot
opened on Mar 9, 2021

@ianlancetaylor requested issue #44887 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open backport to 1.16

In some cases t.Helper seems to be ineffective. It's not critical but it's definitely annoying. We should fix it.

Activity

  1. gopherbot
    added
    CherryPickCandidateUsed during the release process for point releases
    on Mar 9, 2021
  2. gopherbot
    added this to the Go1.16.1 milestone on Mar 9, 2021
  3. toothrot
    modified the milestones: Go1.16.1, Go1.16.2 on Mar 10, 2021
  4. cagedmantis
    modified the milestones: Go1.16.2, Go1.16.3 on Mar 11, 2021

  5. gopherbot commented on Mar 19, 2021

    @gopherbot
    gopherbot
    on Mar 19, 2021
    ContributorAuthor

    Change https://golang.org/cl/303189 mentions this issue: [release-branch.go1.16] testing: update helperNames just before checking it

  6. toothrot
    added
    CherryPickApprovedUsed during the release process for point releases
    on Mar 24, 2021

  7. toothrot commented on Mar 24, 2021

    @toothrot
    toothrot
    on Mar 24, 2021
    Contributor

    Approved. There's no workaround and this regression makes t.Helper not very useful.

  8. gopherbot
    removed
    CherryPickCandidateUsed during the release process for point releases
    on Mar 24, 2021

  9. gopherbot commented on Mar 24, 2021

    @gopherbot
    gopherbot
    on Mar 24, 2021
    ContributorAuthor

    Closed by merging 902d16e to release-branch.go1.16.

  10. gopherbot
    closed this as completedon Mar 24, 2021
  11. gopherbot
    added a commit that references this issue on Mar 24, 2021

    [release-branch.go1.16] testing: update helperNames just before check…

    902d16e
  12. golang
    locked and limited conversation to collaborators on Mar 24, 2022
  13. gopherbot
    added
    FrozenDueToAge
    on Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CherryPickApprovedUsed during the release process for point releasesFrozenDueToAge

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions