Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: map insertion should overwrite existing keys #45045

Closed
randall77 opened this issue Mar 16, 2021 · 4 comments
Closed

runtime: map insertion should overwrite existing keys #45045

randall77 opened this issue Mar 16, 2021 · 4 comments
Labels
Milestone

Comments

@randall77
Copy link
Contributor

@randall77 randall77 commented Mar 16, 2021

Looks like this happens correctly in mapassign, but not in the mapassign_faststr variant.

@mdempsky

First noticed as part of #45021

@randall77 randall77 added this to the Go1.17 milestone Mar 16, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 26, 2021

Change https://golang.org/cl/305089 mentions this issue: runtime: overwrite existing keys for mapassign_faststr variant

Loading

@gopherbot gopherbot closed this in 23ffb5b Mar 28, 2021
@networkimprov
Copy link

@networkimprov networkimprov commented Mar 28, 2021

Backport candidate?

Loading

@cuonglm
Copy link
Member

@cuonglm cuonglm commented Mar 28, 2021

Backport candidate?

I don't think this can be qualified for backport.

Loading

@randall77
Copy link
Contributor Author

@randall77 randall77 commented Mar 28, 2021

I agree. This is not a serious enough problem to warrant a backport.

https://github.com/golang/go/wiki/MinorReleases

A “serious” problem is one that prevents a program from working at all.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants