Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/poll: TestSplicePipePool failures on linux builders #45059

Closed
bcmills opened this issue Mar 16, 2021 · 8 comments
Closed

internal/poll: TestSplicePipePool failures on linux builders #45059

bcmills opened this issue Mar 16, 2021 · 8 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Mar 16, 2021

--- FAIL: TestSplicePipePool (1.07s)
    splice_linux_test.go:61: at least one pipe is still open
FAIL
FAIL	internal/poll	1.254s

2021-03-16T13:06:04-26c32de/linux-386-sid
2021-03-14T21:10:45-3cdd5c3/linux-arm

CC @panjf2000 @ianlancetaylor @bradfitz

@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 16, 2021

This test was added during the current release cycle (March 9, in CL 271537 for #42740), so marking as release-blocker for Go 1.17.

@bcmills bcmills added this to the Go1.17 milestone Mar 16, 2021
@panjf2000
Copy link
Contributor

@panjf2000 panjf2000 commented Mar 17, 2021

This looks more like an episodic failure?

@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 17, 2021

Yes, it is intermittent. An intermittent failure is nonetheless a failure.

@toothrot
Copy link
Contributor

@toothrot toothrot commented Apr 1, 2021

@bcmills @panjf2000 Friendly ping as this issue is labeled as a release-blocker for Go 1.17.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Apr 7, 2021

@toothrot, I don't have the bandwidth to look into this at the moment. If no one else does either, then I suggest we roll back CL 271537 until it can be fixed.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 7, 2021

Change https://golang.org/cl/308089 mentions this issue: Revert "internal/poll: implement a pipe pool for splice() call"

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 8, 2021

Change https://golang.org/cl/308329 mentions this issue: internal/poll: bump up the number of iterations in the test loop

@gopherbot gopherbot closed this in 6382ec1 Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants