Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/analysis/passes/inspect: typo in comment in inspect.go #45079

Closed
Aseiide opened this issue Mar 17, 2021 · 4 comments
Closed

x/tools/go/analysis/passes/inspect: typo in comment in inspect.go #45079

Aseiide opened this issue Mar 17, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix Tools
Milestone

Comments

@Aseiide
Copy link

@Aseiide Aseiide commented Mar 17, 2021

What version of Go are you using (go version)?

$ go version
go version go1.16.2 darwin/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/aseiide/Library/Caches/go-build"
GOENV="/Users/aseiide/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/aseiide/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/aseiide/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16.2"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/tj/6bk6q_71181_9x4vwmvbv4j40000gn/T/go-build4051281720=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

When I read this documentation, I found the broken link.

https://github.com/golang/tools/blob/master/go/analysis/passes/inspect/inspect.go#L6
// (golang.org/x/tools/go/ast/inspect.Inspect) for the syntax trees of a

When I try to jump to this link, I get Not found. like this.
スクリーンショット 2021-03-17 19 09 22

What did you expect to see?

I suggest fix it to the correct url.

What did you see instead?

I think this link is correct.

//(golang.org/x/tools/go/analysis/passes/inspect) for the syntax trees of a

@gopherbot gopherbot added the Tools label Mar 17, 2021
@gopherbot gopherbot added this to the Unreleased milestone Mar 17, 2021
@andreybokhanko
Copy link
Contributor

@andreybokhanko andreybokhanko commented Mar 17, 2021

This is a type name, not a URL. But indeed, it's incorrect -- should end with "inspector.Inspector".

Let me submit a patch in a few mins.

@ianlancetaylor please assign on me.

Yours,
Andrey
===
Advanced Software Technology Lab
Huawei

@andreybokhanko
Copy link
Contributor

@andreybokhanko andreybokhanko commented Mar 17, 2021

Code review request submitted: https://go-review.googlesource.com/c/go/+/302570

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 17, 2021

Change https://golang.org/cl/302570 mentions this issue: cmd/vendor: Fix a typo in a comment

@cherrymui cherrymui added the NeedsFix label Mar 17, 2021
@cherrymui cherrymui changed the title x/tools/go/analysis/passes/inspect/inspect.go I found broken link x/tools/go/analysis/passes/inspect: typo in comment in inspect.go Mar 17, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 18, 2021

Change https://golang.org/cl/302989 mentions this issue: cmd/vendor: Fix a typo in a comment

@golang golang locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix Tools
Projects
None yet
Development

No branches or pull requests

4 participants