x/pkgsite: recognize and ignore the PSF license stack instead of failing entirely as UNKNOWN. #45095
What is the URL of the page with the issue?
What is your user agent?
Mozilla/5.0 (X11; CrOS x86_64 13597.105.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.208 Safari/537.36
What did you do?
Include the Python Software Foundation "license stack" in the Apache Beam LICENSE file.
What did you expect to see?
Licences: Apache-2.0, BSD-3-Clause, MIT, PSF
What did you see instead?
Prior to including the PSF License, the file was parsed properly, and listed all the licenses, and after the license file was truncated in error, the Apache 2.0 license was correctly listed.
While probably not common, large enough projects in multiple languages can have Go releases (like Apache Beam) and also include Python which is very much under it's own license, that doesn't prohibit the redistribution necessary for pkg.go.dev. I propose the PSF license is added to the set of "known" licenses, if only to avoid the bad state.
Even if the PSF isn't determined as recognized, failing into UNKNOWN when other licenses parse correctly seems like a bad behavior.
The text was updated successfully, but these errors were encountered:
I'm working on getting legal approval for the PSF license.
Meanwhile, your text does not match the official OSI license text or the licensecheck regular expression that matches it. For example, you have extra years in the copyright example in section 2 (note that it's only an example, not an actual copyright notice, so no need to add years). And there are differences in the CNI section, for instance you omit
For golang/go#45095 Change-Id: Iea030936f382535ec82b64f40fe4b4effc2f5d8f Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/303129 Trust: Jonathan Amsterdam <firstname.lastname@example.org> Run-TryBot: Jonathan Amsterdam <email@example.com> Reviewed-by: Julie Qiu <firstname.lastname@example.org> TryBot-Result: kokoro <email@example.com>