Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: regression in source.fixAll diagnostics #45111

Closed
stamblerre opened this issue Mar 18, 2021 · 1 comment
Closed

x/tools/gopls: regression in source.fixAll diagnostics #45111

stamblerre opened this issue Mar 18, 2021 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Mar 18, 2021

Some source.fixAll and quickfix diagnostics are now labeled as only quickfix, even when we should return source.fixAll diagnostics so that they can be applied on save. This is preventing fillreturns quick fixes from being applied on save.

/cc @heschik

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 19, 2021

Change https://golang.org/cl/303209 mentions this issue: internal/lsp: fix support for SourceFixAll code actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants