Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: adjust type checking of string(1 << s) pending issue #45114 #45117

Open
griesemer opened this issue Mar 19, 2021 · 2 comments
Open
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Mar 19, 2021

Reminder issue: Currently both go/types and types2 accept string(1 << s) while the compilers don't.

For details see #45114.

cc: @findleyr

@griesemer griesemer added this to the Backlog milestone Mar 19, 2021
@griesemer griesemer self-assigned this Mar 19, 2021
@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Mar 19, 2021

If we disallow this, re-enable the disabled test in test/fixedbugs/bug193.go.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 19, 2021

Change https://golang.org/cl/303094 mentions this issue: test: enable fixedbugs/bug193.go for -G compiler option

gopherbot pushed a commit that referenced this issue Mar 23, 2021
Temporarily disable a questionable test case in fixedbugs/bug193.go
and enable the test as a whole. See the issues below for details.

Updates #45114.
Updates #45117.

Change-Id: I1de6f8d79b592eeeec139cd92b6c9cac56a9a74b
Reviewed-on: https://go-review.googlesource.com/c/go/+/303094
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants