Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: BenchmarkTCP4ConcurrentReadWrite failures on freebsd-amd64-race with "read: connection reset by peer" #45214

Open
bcmills opened this issue Mar 24, 2021 · 7 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Mar 24, 2021

2021-03-23T05:12:12-cd26192/freebsd-amd64-race
2021-03-23T04:23:52-0265b64/freebsd-amd64-race

(See also #20960.)

CC @bradfitz @ianlancetaylor

These failures are both very recent, so I wonder if something has recently changed in the net package or the freebsd-amd64-race builders. (CC @golang/release)

@bcmills bcmills added this to the Backlog milestone Mar 24, 2021
@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 24, 2021

#19229 also features connection reset by fail errors on FreeBSD. I wonder if it's related...

@ayang64
Copy link
Contributor

@ayang64 ayang64 commented Mar 25, 2021

which version of freebsd? i can't reproduce on FreeBSD kiwi 14.0-CURRENT FreeBSD 14.0-CURRENT #5 main-n245559-d22883d71544: Sun Mar 21 16:51:44 EDT 2021 root@kiwi:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG amd64

@ayang64
Copy link
Contributor

@ayang64 ayang64 commented Mar 25, 2021

also, are you running freebsd in a virtual machine for tests?

@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 25, 2021

Looks like it's FreeBSD 12.0 of some flavor, on a GCE n1-highcpu-16 VM:
https://github.com/golang/build/blob/d7600ec889c89d486672e9ccd1b30bab50c15047/dashboard/builders.go#L317-L324

@golang/release could probably get you more details.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 25, 2021

The failure rate is not particularly high, so you may also need a lot of runs to reproduce the failure.

@ayang64
Copy link
Contributor

@ayang64 ayang64 commented Mar 25, 2021

okay -- i just ran it on my local machine with -count 100 without any failures. i'll continue trying to reproduce and maybe try to isolate the commit that caused it. i'll also try under 12.0.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 25, 2021

There's one more in the logs today:
2021-03-25T00:15:42-80157b5/freebsd-amd64-race

That's three in two days, and none that I can find before that. So the regression is probably very recent, whatever it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants