Skip to content

x/net/http2: data race in test from logging in onSameConn callback #45237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Mar 25, 2021 · 2 comments
Closed

x/net/http2: data race in test from logging in onSameConn callback #45237

bcmills opened this issue Mar 25, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 25, 2021

This may have the same underlying cause as #37510 and/or #38370.

2021-03-24T20:56:30-d1beb07/freebsd-amd64-race
2021-03-24T20:56:30-d1beb07/linux-amd64-race
2021-03-23T14:18:57-08027d5/windows-amd64-race
2021-02-26T17:20:49-e18ecbb/freebsd-amd64-race
2021-02-22T17:17:44-9060382/linux-amd64-race
2021-01-19T19:43:25-5f4716e/windows-amd64-race
2020-12-16T05:46:12-986b41b/freebsd-amd64-race
2020-10-26T09:15:29-146b70c/freebsd-amd64-race
2020-10-16T16:51:38-7b1cca2/windows-amd64-race
2020-09-27T03:25:02-5d4f700/freebsd-amd64-race
2020-09-27T03:25:02-5d4f700/windows-amd64-race
2020-08-13T13:45:08-3edf25e/freebsd-amd64-race
2020-07-07T03:43:11-ab34263/freebsd-amd64-race
2020-05-28T22:51:25-3c3fba1/windows-amd64-race
2020-05-20T18:23:14-0ba52f6/windows-amd64-race
2020-05-13T18:57:01-a91f071/windows-amd64-race
2020-04-25T23:01:54-ff2c4b7/freebsd-amd64-race
2020-03-24T14:37:07-d3edc99/freebsd-amd64-race
2020-03-19T23:41:17-63522db/freebsd-amd64-race
2020-02-22T12:55:58-5a598a2/windows-amd64-race
2020-02-19T18:36:55-4628272/freebsd-amd64-race
2020-01-14T15:54:13-6afb519/freebsd-amd64-race
2019-12-09T16:08:50-c0dbc17/windows-amd64-race
2019-10-28T08:55:09-fe3aa8a/freebsd-amd64-race
2019-09-21T01:59:27-1a5e07d/windows-amd64-race
2019-04-04T23:23:15-eb5bcb5/linux-amd64-race
2019-03-27T21:43:58-63eda1e/freebsd-amd64-race

CC @neild @bradfitz @tombergan @empijei
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 25, 2021
@bcmills bcmills added this to the Backlog milestone Mar 25, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/304829 mentions this issue: net/http/httptest: wait for user ConnState hooks

This was referenced Nov 29, 2021
Closed
Open
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/367516 mentions this issue: [release-branch.go1.16] net/http/httptest: wait for user ConnState hooks

gopherbot pushed a commit that referenced this issue Dec 1, 2021
@neild @mknyszek
[release-branch.go1.16] net/http/httptest: wait for user ConnState hooks
0f9838e 
Ensure that user ConnState callbacks have completed before returning
from (*httptest.Server).Close.

Fixes: #49851
Updates: #37510
Updates: #37505
Updates: #45237

Change-Id: I8fe7baa089fbe4f3836bf6ae9767c7b1270d1331
Reviewed-on: https://go-review.googlesource.com/c/go/+/304829
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit 5cec8b8)
Reviewed-on: https://go-review.googlesource.com/c/go/+/367516
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
@golang golang locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot