Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: Europe/Dublin timezone handling broken with embedded timezone database [1.16 backport] #45385

Open
gopherbot opened this issue Apr 4, 2021 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 4, 2021

@ianlancetaylor requested issue #45370 to be considered for backport to the next 1.16 minor release.

@gopherbot Please open a backport issue.

This issue will cause incorrect timezone information to be used on systems using the slim tzdata format, which are increasingly likely as it is now the default.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 5, 2021

Change https://golang.org/cl/307210 mentions this issue: [release-branch.go1.16] time: add Time.IsDST() to check if its Location is in Daylight Savings Time

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 5, 2021

Change https://golang.org/cl/307211 mentions this issue: [release-branch.go1.16] time: use offset and isDST when caching zone from extend string

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Apr 8, 2021

Approving per discussion in a release meeting. This backport applies to both 1.16 (this issue) and 1.15 (#45384).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants