Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: detects full text of GPL3 licenses as both GPL3 and GPL2 #45432

Closed
heschi opened this issue Apr 7, 2021 · 2 comments
Closed

x/pkgsite: detects full text of GPL3 licenses as both GPL3 and GPL2 #45432

heschi opened this issue Apr 7, 2021 · 2 comments

Comments

@heschi
Copy link
Contributor

@heschi heschi commented Apr 7, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/netdata/go.d.plugin, but this is just an example.

What did you do?

Looked at the licenses for this module, which contains (I think) a verbatim copy of the GPL3 page at https://www.gnu.org/licenses/gpl-3.0.en.html.

What did you expect to see?

GPL3.

What did you see instead?

GPL3 and GPL2.

@julieqiu showed me the license detector information for the module, which at a glance suggests that it's detecting the text in the "How to apply these terms to your software" section as GPL2, despite the rather critical "version 3" in it.

@gopherbot gopherbot added the pkgsite label Apr 7, 2021
@gopherbot gopherbot added this to the Unreleased milestone Apr 7, 2021
@jba jba self-assigned this Apr 7, 2021
@jba jba modified the milestones: Unreleased, pkgsite/unplanned Apr 7, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 8, 2021

Change https://golang.org/cl/308449 mentions this issue: internal/licenses: add alternative GPL-3 URL

gopherbot pushed a commit to golang/pkgsite that referenced this issue Apr 8, 2021
The "why not LGPL" link has apparently changed.
Accept both links.

For golang/go#45432

Change-Id: I1a252b11b1995bcd33c527473d111a17e0db55a2
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/308449
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
@jba
Copy link
Contributor

@jba jba commented Apr 12, 2021

I fixed the problem and updated our database.

@jba jba closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants