Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: "invalid pc-encoded table" throw caused by bad cgo traceback (expandFinalInlineFrames) [1.15 backport] #45481

Closed
gopherbot opened this issue Apr 9, 2021 · 3 comments
Closed

runtime: "invalid pc-encoded table" throw caused by bad cgo traceback (expandFinalInlineFrames) [1.15 backport] #45481

gopherbot opened this issue Apr 9, 2021 · 3 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.15.12

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 9, 2021

@prattmic requested issue #45480 to be considered for backport to the next 1.15 minor release.

@gopherbot please open a backport for 1.16 and 1.15. The only workaround is to change the C traceback engine, which isn't usually feasible. This is a follow-up CL for a previously missed case.
@gopherbot gopherbot added the CherryPickCandidate label Apr 9, 2021
@gopherbot gopherbot mentioned this issue Apr 9, 2021
Closed
@gopherbot gopherbot added this to the Go1.15.12 milestone Apr 9, 2021
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Apr 12, 2021

No workaround, relatively safe fix.

@mknyszek mknyszek added CherryPickApproved and removed CherryPickCandidate labels Apr 12, 2021
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 12, 2021

Change https://golang.org/cl/309550 mentions this issue: [release-branch.go1.15] runtime: non-strict InlTreeIndex lookup in expandFinalInlineFrame

@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 4, 2021

Closed by merging c0a7ecf to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue May 4, 2021
@prattmic @cagedmantis
[release-branch.go1.15] runtime: non-strict InlTreeIndex lookup in ex…
c0a7ecf 
…pandFinalInlineFrame

This is a follow-up to golang.org/cl/301369, which made the same change
in Frames.Next. The same logic applies here: a profile stack may have
been truncated at an invalid PC provided by cgoTraceback.
expandFinalInlineFrame will then try to lookup the inline tree and
crash.

The same fix applies as well: upon encountering a bad PC, simply leave
it as-is and move on.

For #44971
For #45480
Fixes #45481

Change-Id: I2823c67a1f3425466b05384cc6d30f5fc8ee6ddc
Reviewed-on: https://go-review.googlesource.com/c/go/+/309109
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Trust: Michael Pratt <mpratt@google.com>
(cherry picked from commit aad13cb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/309550
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
Go1.15.12
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot