Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: exit during example test is mysterious #4550

Closed
rsc opened this issue Dec 15, 2012 · 4 comments
Closed

testing: exit during example test is mysterious #4550

rsc opened this issue Dec 15, 2012 · 4 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Dec 15, 2012

If an Example test prints to standard error and then exits, standard error is buffered
so it doesn't show up. The test just exits. This is VERY confusing.

One fix would be to not include standard error in the matched output.
@adg
Copy link
Contributor

@adg adg commented Dec 19, 2012

Comment 1:

I think the proposed fix is a fine one. I don't see any examples in the standard library
that print to standard error for anything other than error conditions.

Status changed to WaitingForReply.

@adg
Copy link
Contributor

@adg adg commented Dec 19, 2012

Comment 2:

Status changed to Started.

@adg
Copy link
Contributor

@adg adg commented Dec 19, 2012

Comment 3:

Sent CL: https://golang.org/cl/6973048
@adg
Copy link
Contributor

@adg adg commented Dec 19, 2012

Comment 4:

This issue was closed by revision ff5d47e.

Status changed to Fixed.

@rsc rsc added fixed labels Dec 19, 2012
@rsc rsc assigned adg Dec 19, 2012
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.