Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Effective Go section about Errors uses type assertion without mentioning errors.As #45535

Open
ChrisHines opened this issue Apr 13, 2021 · 2 comments

Comments

@ChrisHines
Copy link
Contributor

@ChrisHines ChrisHines commented Apr 13, 2021

What version of Go are you using (go version)?

n/a

Does this issue reproduce with the latest release?

n/a

What operating system and processor architecture are you using (go env)?

n/a

What did you do?

Read about errors in "Effective Go"

What did you expect to see?

Examples that use the current best way of inspecting concrete error values or acknowledgment that there is a better way with a reference to details about the alternatives.

What did you see instead?

Use of a type assertion in the style typically used with Go 1.12 and earlier without any mention of errors.As available since Go 1.13.

@fzipp
Copy link
Contributor

@fzipp fzipp commented Apr 13, 2021

See #28782

@mknyszek mknyszek added this to the Backlog milestone Apr 13, 2021
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Apr 13, 2021

Marking needs decision. I think whether this is fixed is wholly dependent on #28782, but it's still useful to have this issue linked and hanging around to add to the pile of related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants