Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: structtag field json warning for _ #45536

Closed
colin-sitehost opened this issue Apr 13, 2021 · 3 comments
Closed

cmd/vet: structtag field json warning for _ #45536

colin-sitehost opened this issue Apr 13, 2021 · 3 comments

Comments

@colin-sitehost
Copy link

@colin-sitehost colin-sitehost commented Apr 13, 2021

What version of Go are you using (go version)?

$ go version
go version go1.16.3 linux/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOENV="/home/user/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/user/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/user/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.3"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/user/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2204759132=/tmp/go-build -gno-record-gcc-switches"

What did you do?

type Struct struct{
        One   string `json:"one"`
        Two   string `json:"_"`
        Three string `json:"_"`
}

What did you expect to see?

Structtag should be aware of the special meaning of `json:"_"` and succeed.

Maybe we can ignore any `xxx:"_"` tags? I think it is out of scope for structtag to be aware of all the repeatable sentinals for struct tags, since third parties can ignore these lints.

What did you see instead?

structtag: struct field Three repeats json tag "_" also at main.go:5
@dsnet
Copy link
Member

@dsnet dsnet commented Apr 13, 2021

Structtag should be aware of the special meaning of json:"_" and succeed.

I'm not aware of any special meaning for json:"_". Did you mean json:"-"?

@colin-sitehost
Copy link
Author

@colin-sitehost colin-sitehost commented Apr 13, 2021

yep, the issue was a typo not a vet bug; sorry for the confusion.

@dsnet
Copy link
Member

@dsnet dsnet commented Apr 13, 2021

No worries, easy confusion to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants