x/net/http2: no way to set timeouts on http2.Transport

[mhr3]

I'm using the http2.Transport with a h2c client, which works fine, but there is no way to set timeouts which are normally inherited from regular http.Transport - for example ExpectContinueTimeout, which when using manually constructed http2.Transport{} is always set to 0, and therefore the client doesn't wait for the 100-continue response.

What version of Go are you using (go version)?

$ go version
go version go1.15.2 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="linux"

What did you do?

Sent a h2c client request with Expect: 100-continue, but the client doesn't wait to send the body because there's no way to set the ExpectContinueTimeout, which means it ends up being 0.

What did you expect to see?

There should be a way to set the timeouts, so the client would have waited to send the request body.

[mknyszek]

CC @bradfitz @tombergan via https://dev.golang.org/owners

(I will also CC @neild)

[neild]

Use http2.ConfigureTransports to construct an http2.Transport with HTTP/1 configuration options.

t1 := &http.Transport{
  ExpectContinueTimeout: 1*time.Second, // for example
}
t2, err := http2.ConfigureTransports(t1)
if err != nil {
  return err
}
t2.DisableCompression = true // for example

[mhr3]

Use http2.ConfigureTransports to construct an http2.Transport with HTTP/1 configuration options.

I've actually tried that, but then the client was refusing to dial the connection, and only now did I try to also set the t2.ConnPool to nil, which seems to work. 🤦🏼

[networkimprov]

cc @fraenkel