flag: Value example use code that is reported by golint

[perillo]

What version of Go are you using (go version)?

$ go version
go version go1.16.3 linux/amd64

Does this issue reproduce with the latest release?

Yes.

The Value example in the flag package (https://golang.org/pkg/flag/#example_Value) uses the code:

if u, err := url.Parse(s); err != nil {
	return err
} else {
	*v.URL = *u
}
return nil

golint reports:
if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary).

Not sure if the code should be modified.

Thanks.

[ianlancetaylor]

Sure, we can change the example code. Thanks.

[gopherbot]

Change https://golang.org/cl/311269 mentions this issue: flag: improve coding style in Value example

[mvdan]

The change was abandoned; closing.