Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: address formatting issues with go-diff@v1.2.0 #45732

Open
findleyr opened this issue Apr 23, 2021 · 1 comment
Open

x/tools/gopls: address formatting issues with go-diff@v1.2.0 #45732

findleyr opened this issue Apr 23, 2021 · 1 comment
Assignees
Milestone

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented Apr 23, 2021

In #45648, we discovered that gopls has formatting bugs when built with github.com/sergi/go-diff@v1.2.0. Unfortunately, there are probably many users that get this version due to installing with go get -u.

Until sergi/go-diff#115 is fixed, or we find some other solution, we should at least warn users when built with go-diff@v1.2.0.

CC @stamblerre @heschi

@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2021
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.6.11 Apr 23, 2021
@suzmue suzmue changed the title x/tools/gopls: guard against formatting issues with go-diff@v1.2.0 x/tools/gopls: address formatting issues with go-diff@v1.2.0 Apr 30, 2021
@stamblerre stamblerre self-assigned this Apr 30, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 30, 2021

Change https://golang.org/cl/315852 mentions this issue: internal/lsp: warn users who have built gopls with go-diff v1.2.0

gopherbot pushed a commit to golang/tools that referenced this issue May 3, 2021
I considered having gopls not initialize at all, but VS Code Go
intercepts those error messages and they get buried. We should probably
fix that in VS Code Go, but for now just show a warning.

Updates golang/go#45732

Change-Id: I214974e5a96231c96b1583af8ac245de03cea5d8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/315852
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants