Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pprof: source view is always blank at tip (due to upstream pprof bug) #45786

Open
zikaeroh opened this issue Apr 26, 2021 · 2 comments
Open

pprof: source view is always blank at tip (due to upstream pprof bug) #45786

zikaeroh opened this issue Apr 26, 2021 · 2 comments

Comments

@zikaeroh
Copy link
Contributor

@zikaeroh zikaeroh commented Apr 26, 2021

What version of Go are you using (go version)?

$ go version
go version devel go1.17-0d1280c685 Mon Apr 26 18:54:39 2021 +0000 linux/amd64

Does this issue reproduce with the latest release?

On tip, yes, in Go 1.16, no.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jake/.cache/go-build"
GOENV="/home/jake/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/jake/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/jake/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/jake/sdk/gotip"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/jake/sdk/gotip/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel go1.17-0d1280c685 Mon Apr 26 18:54:39 2021 +0000"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build4162563244=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version devel go1.17-0d1280c685 Mon Apr 26 18:54:39 2021 +0000 linux/amd64
GOROOT/bin/go tool compile -V: compile version devel go1.17-0d1280c685 Mon Apr 26 18:54:39 2021 +0000
uname -sr: Linux 5.11.16-zen1-1-zen
/usr/lib/libc.so.6: GNU C Library (GNU libc) release release version 2.33.
gdb --version: GNU gdb (GDB) 10.1

What did you do?

$ gotip test -run=- -bench 'Write' -benchmem -cpuprofile cpu.out -memprofile mem.out encoding/csv
$ gotip tool pprof -http=: mem.out

Then navigate to the "source" view at the top left.

What did you expect to see?

A page containing the source of the benchmarked code.

What did you see instead?

The source page is always empty with Go profiles.

This issue is technically google/pprof#621, but as pprof is vendored into Go and the current version is broken (and the freeze is quite soon), I wanted to ensure this was triaged here.

@ALTree
Copy link
Member

@ALTree ALTree commented Apr 26, 2021

Thanks for reporting this, let's label this as a 1.17 release-blocker to make sure that when (if) the bug is fixed upstream, we vendor the fix before the 1.17 release (or at least decide if we want to).

@ALTree ALTree added this to the Go1.17 milestone Apr 26, 2021
@ALTree ALTree changed the title pprof: source view is always blank at tip pprof: source view is always blank at tip (due to upstream pprof bug) Apr 26, 2021
@toothrot
Copy link
Contributor

@toothrot toothrot commented Apr 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants