Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: unexpected trampoline when cross-compiling to ppc64le [1.16 backport] #45832

Closed
gopherbot opened this issue Apr 28, 2021 · 3 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 28, 2021

@pmur requested issue #45564 to be considered for backport to the next 1.16 minor release.

@gopherbot please consider a backport to 1.16. This seems to a be a regression from go 1.16.1 to 1.16.2.

I don't think a backport to earlier versions is necessary since the issue likely affects all 1.15 releases. It might be possible to workaround by not disabling cgo, or using external linking.

@toothrot
Copy link
Contributor

@toothrot toothrot commented Apr 29, 2021

Approved. This is a serious issue with no workaround.

Loading

@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 3, 2021

Change https://golang.org/cl/316329 mentions this issue: [release-branch.go.16] cmd/link: disable plugin support if cgo is disabled

Loading

@heschi heschi removed this from the Go1.16.4 milestone May 6, 2021
@heschi heschi added this to the Go1.16.5 milestone May 6, 2021
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 20, 2021

Closed by merging c7248a0 to release-branch.go1.16.

Loading

@gopherbot gopherbot closed this May 20, 2021
gopherbot pushed a commit that referenced this issue May 20, 2021
…sabled

Functional plugin support requires cgo to be enabled. Disable
it if the environment has disabled cgo.

This prevents unexpected linker failures when linking large
binaries with cgo disabled which use the plugin package.

Fixes #45832

Change-Id: Ib71f0e089f7373b7b3e3cd53da3612291e7bc473
Reviewed-on: https://go-review.googlesource.com/c/go/+/314449
Run-TryBot: Paul Murphy <murp@ibm.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
(cherry picked from commit 983dea9)
Reviewed-on: https://go-review.googlesource.com/c/go/+/316329
Reviewed-by: Cherry Mui <cherryyz@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants