Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text/template: Node.String() should reproduce the original template #4593

Closed
moraes opened this issue Dec 28, 2012 · 5 comments
Closed

text/template: Node.String() should reproduce the original template #4593

moraes opened this issue Dec 28, 2012 · 5 comments
Assignees
Milestone

Comments

@moraes
Copy link
Contributor

@moraes moraes commented Dec 28, 2012

I think the text representation of template Nodes should result in the same template
output, when parsed.

Node.String() methods all follow this direction, except TextNode, which outputs the
template text quoted using %q. It should use %s.

This is a really small thing, but I see no reason why Node.String() could not result in
template snippets that reproduce the original. Am I missing something?
@rsc
Copy link
Contributor

@rsc rsc commented Dec 30, 2012

Comment 1:

Labels changed: added priority-later, go1.1maybe, removed priority-triage, go1.1.

Status changed to Thinking.

@rsc
Copy link
Contributor

@rsc rsc commented Mar 12, 2013

Comment 2:

[The time for maybe has passed.]

Labels changed: removed go1.1maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 3:

Labels changed: added go1.2maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 4:

Owner changed to @robpike.

@robpike
Copy link
Contributor

@robpike robpike commented Jul 31, 2013

Comment 5:

This issue was closed by revision df4de94.

Status changed to Fixed.

@moraes moraes added fixed labels Jul 31, 2013
@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.