Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: test is timing out on plan9-arm #45941

Closed
millerresearch opened this issue May 4, 2021 · 3 comments
Closed

os: test is timing out on plan9-arm #45941

millerresearch opened this issue May 4, 2021 · 3 comments

Comments

@millerresearch
Copy link

@millerresearch millerresearch commented May 4, 2021

The os test has been timing out on plan9-arm after 18m on every run, apparently since CL313514

@millerresearch
Copy link
Author

@millerresearch millerresearch commented May 4, 2021

The TestExecutableDeleted test is hanging when subprocess testdel.exe goes into Plan 9 "Broken" state instead of exiting. This behaviour seems to be new with commit 02ab8d1.

@millerresearch
Copy link
Author

@millerresearch millerresearch commented May 4, 2021

Looking at the source of testdel.exe, I'm surprised this test has ever passed on Plan 9. The program deletes its own executable file while running, which is likely to cause it to crash because Plan 9 does demand paging directly from the executable file and doesn't protect files from deletion while being executed. I think the commit must have had the side effect of changing the program's paging behaviour such that it now touches a previously unreferenced page after the file deletion,.

This test is already skipped on windows, openbsd, freebsd, and aix. I think it should be skipped on plan9 too.

@gopherbot
Copy link

@gopherbot gopherbot commented May 4, 2021

Change https://golang.org/cl/316829 mentions this issue: os: skip TestExecutableDeleted on plan9

@gopherbot gopherbot closed this in 8c3d217 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants