Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: memoize allKnownSubdirs on the snapshot #45974

Closed
stamblerre opened this issue May 5, 2021 · 2 comments
Closed

x/tools/gopls: memoize allKnownSubdirs on the snapshot #45974

stamblerre opened this issue May 5, 2021 · 2 comments
Assignees
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 5, 2021

@findleyr profiled didChange and found that this function was taking up the most time in didModifyFiles events, so we should cache the directories on the snapshot.

@stamblerre stamblerre added this to the gopls/v0.6.12 milestone May 5, 2021
@stamblerre stamblerre self-assigned this May 5, 2021
@findleyr
Copy link
Contributor

@findleyr findleyr commented May 5, 2021

This was mentioned in #45686, but a forthcoming benchmark suggests that allKnownSubdirs accounts for more than half of the time it takes to process (but not diagnose) a file change.

@gopherbot
Copy link

@gopherbot gopherbot commented May 25, 2021

Change https://golang.org/cl/317410 mentions this issue: internal/lsp: memoize allKnownSubdirs instead of recomputing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants