Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: fails to upload the build logs when they exceed 65536 characters #45998

Closed
cagedmantis opened this issue May 6, 2021 · 2 comments

Comments

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented May 6, 2021

During the Go 1.16.4 (#45995) release, releasebot failed to upload the logs during the prepare step because the logs exceeded the limit by the GitHub api.

error posting update comment: POST https://api.github.com/repos/golang/go/issues/45995/comments: 422 Validation Failed [{Resource:IssueComment Field:data Code:unprocessable Message:Body is too long (maximum is 65536 characters)}]

When the logs exceed 65536 characters, we should either truncate of split the logs into a size that will fit into a GitHub issue comment.

@golang/release

@gopherbot
Copy link

@gopherbot gopherbot commented May 7, 2021

Change https://golang.org/cl/318070 mentions this issue: cmd/releasebot: split the release log into multiple posts if necessary

@cagedmantis cagedmantis self-assigned this May 11, 2021
@dmitshur dmitshur modified the milestones: Backlog, Unreleased May 11, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented May 12, 2021

Change https://golang.org/cl/319352 mentions this issue: cmd/releasebot: fix a typo in a document string

gopherbot pushed a commit to golang/build that referenced this issue May 12, 2021
For golang/go#45998

Change-Id: I411e0ae3bdc9d0537ccc9115f7169e39dd279157
Reviewed-on: https://go-review.googlesource.com/c/build/+/319352
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur added this to Done in Go Release Team May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants