Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: SIGSEGV running 'openshift-install version' for release-4.8 using external linking on PPC64LE [1.15 backport] #46002

Closed
toothrot opened this issue May 6, 2021 · 3 comments

Comments

@toothrot
Copy link
Contributor

@toothrot toothrot commented May 6, 2021

@pmur requested issue #45850 to be considered for backport to the next 1.15 minor release.

@gopherbot this affects building openshift with go1.16, please consider a backport.

@gopherbot
Copy link

@gopherbot gopherbot commented May 7, 2021

Change https://golang.org/cl/317974 mentions this issue: [release-branch.go1.15]cmd/link/internal: fix use of DynlinkingGo with ppc64le trampolines

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented May 21, 2021

Approving per discussion in a release meeting. This backport applies to both 1.16 (#45927) and 1.15 (this issue).

Loading

gopherbot pushed a commit that referenced this issue Jun 2, 2021
…th ppc64le trampolines

When creating programs with large text sections on ppc64le,
trampolines are needed for calls that are too far; however
they are not created if the code is generated such that the TOC
register r2 is initialized and maintained in the code because
then the external linker can create the trampolines. Previously
the function DynlinkingGo was used to determine this but in the
case where plugins are used, this could return true even though
r2 is not valid.

To fix this problem I've added a new function r2Valid which returns
true when the build options indicate that the r2 is
initialized and maintained. Because of the ways that
DynlinkingGo is used I wanted to maintain its previous
behavior.

Fixes #46002

Change-Id: I6d902eba6ad41757aa6474948b79acdbd479cb38
Reviewed-on: https://go-review.googlesource.com/c/go/+/315289
Trust: Lynn Boger <laboger@linux.vnet.ibm.com>
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 9ed736a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/317974
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 2, 2021

Closed by merging 448be06 to release-branch.go1.15.

Loading

@gopherbot gopherbot closed this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants