Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/go1.17: document net/http changes for Go 1.17 #46015

Closed
gopherbot opened this issue May 6, 2021 · 2 comments
Closed

doc/go1.17: document net/http changes for Go 1.17 #46015

gopherbot opened this issue May 6, 2021 · 2 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 6, 2021

As of filing this issue, the Go 1.17 draft release notes contained the following HTML:

net/http

The net/http package now uses the new (*tls.Conn).HandshakeContext with the Request context when performing TLS handshakes in the client or server.

TODO: https://golang.org/cl/235437: add to deadlines only when positive

TODO: https://golang.org/cl/308952: make ReadRequest return an error when requests have multiple Host headers


This TODO needs to be resolved by July 1 so that we can have complete release notes for Beta 1.

A sequence of steps to resolve this issue may be:

  1. Come up with a draft release note entry in this issue, then move the issue to NeedsFix state.
  2. Send a CL with "doc/go1.17:" prefix and include "For #44513. Fixes #46015." in the body.
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 7, 2021

Change https://golang.org/cl/317914 mentions this issue: doc/go1.17: http.ReadRequest return error when request has multiple Host headers.

gopherbot pushed a commit that referenced this issue May 21, 2021
Changes include:
* ReadRequest function now returns an error when a request has multiple
  Host headers.

For #44513.
Updates #46015.

Change-Id: I48ea7c5cee3f1d1a247035fd37191362a53d1f04
Reviewed-on: https://go-review.googlesource.com/c/go/+/317914
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Heschi Kreinick <heschi@google.com>
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 26, 2021

Change https://golang.org/cl/322891 mentions this issue: doc/go1.17: document net/... changes

@gopherbot gopherbot closed this in 1d5298d May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant