-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Closed
Labels
Description
When templates with the same name are parsed together, an error only occurs if all templates are not empty: http://play.golang.org/p/zCOU4ggrqe Only the last test here pass on tip: func TestRedefinition(t *testing.T) { _, err := New("root").Parse(`{{define "t"}}{{end}}{{define "t"}}{{end}}`, "", "", make(map[string]*Tree), nil) if err == nil { t.Errorf("expected error") } _, err = New("root").Parse(`{{define "t"}}a{{end}}{{define "t"}}{{end}}`, "", "", make(map[string]*Tree), nil) if err == nil { t.Errorf("expected error") } _, err = New("root").Parse(`{{define "t"}}{{end}}{{define "t"}}b{{end}}`, "", "", make(map[string]*Tree), nil) if err == nil { t.Errorf("expected error") } _, err = New("root").Parse(`{{define "t"}}a{{end}}{{define "t"}}b{{end}}`, "", "", make(map[string]*Tree), nil) if err == nil { t.Errorf("expected error") } } Is this expected?