Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/cpu: TestPPC64minimalFeatures consistently failing on aix-ppc64 #46040

Closed
bcmills opened this issue May 7, 2021 · 4 comments
Closed

x/sys/cpu: TestPPC64minimalFeatures consistently failing on aix-ppc64 #46040

bcmills opened this issue May 7, 2021 · 4 comments

Comments

@bcmills
Copy link
Member Author

@bcmills bcmills commented May 7, 2021

See previously #30732.

@laboger
Copy link
Contributor

@laboger laboger commented May 7, 2021

The aix builder machine is now Power9.
The way AIX is setting these flags is different from Linux.
On Linux the HWCAP flags for Power8 and Power9 are both true on a Power9 system since they are based on the ISA level and and the ISA for Power9 is a superset of Power8. Looks like AIX sets one or the other.
@Helflym

@martisch
Copy link
Contributor

@martisch martisch commented May 10, 2021

I think we should fix this by aligning the AIX behaviour to the Linux behaviour. When Power9 is queried and returns true on aix we should set both Power8 and Power9 cpu feature bools.

@gopherbot
Copy link

@gopherbot gopherbot commented May 10, 2021

Change https://golang.org/cl/318549 mentions this issue: cpu: set PPC64.IsPOWER8 for Power9 on aix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants