Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/cpu: TestPPC64minimalFeatures consistently failing on aix-ppc64 #46040

Closed
bcmills opened this issue May 7, 2021 · 4 comments
Closed

x/sys/cpu: TestPPC64minimalFeatures consistently failing on aix-ppc64 #46040

bcmills opened this issue May 7, 2021 · 4 comments
Labels
arch-ppc64x FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX
Milestone

Comments

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX arch-ppc64x labels May 7, 2021
@bcmills bcmills added this to the Backlog milestone May 7, 2021
@bcmills
Copy link
Member Author

bcmills commented May 7, 2021

See previously #30732.

@laboger
Copy link
Contributor

laboger commented May 7, 2021

The aix builder machine is now Power9.
The way AIX is setting these flags is different from Linux.
On Linux the HWCAP flags for Power8 and Power9 are both true on a Power9 system since they are based on the ISA level and and the ISA for Power9 is a superset of Power8. Looks like AIX sets one or the other.
@Helflym

@martisch
Copy link
Contributor

I think we should fix this by aligning the AIX behaviour to the Linux behaviour. When Power9 is queried and returns true on aix we should set both Power8 and Power9 cpu feature bools.

@gopherbot
Copy link

Change https://golang.org/cl/318549 mentions this issue: cpu: set PPC64.IsPOWER8 for Power9 on aix

@golang golang locked and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-ppc64x FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-AIX
Projects
None yet
Development

No branches or pull requests

4 participants