Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: wrong argument order in DIE of function that has some arguments on the stack #46055

Closed
aarzilli opened this issue May 8, 2021 · 2 comments

Comments

@aarzilli
Copy link
Contributor

@aarzilli aarzilli commented May 8, 2021

$ go version
go version devel go1.17-4c8f48ed4f Sat May 8 05:57:31 2021 +0000 linux/amd64

Compile this function:

func regabistacktest(s1, s2, s3, s4, s5 string, n uint8) (string, string, string, string, string, uint8) {
	return s1+s2, s2+s3, s3+s4, s4+s5, s5+s1, 2*n
}

with -N -l, main.regabistacktest's DIE has the arguments in the order: s1, s2, s3, s4, n, s5 instead of s1, s2, s3, s4, s5, n.

cc @thanm

@thanm thanm self-assigned this May 8, 2021
@thanm
Copy link
Contributor

@thanm thanm commented May 8, 2021

Thanks, I'll take a look. I thought we had that sorted out already, but apparently not.

@gopherbot
Copy link

@gopherbot gopherbot commented May 11, 2021

Change https://golang.org/cl/318829 mentions this issue: cmd/compile/internal/dwarfgen: fix DWARF param DIE ordering

@golang golang locked and limited conversation to collaborators May 13, 2022
@rsc rsc unassigned thanm Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants