x/tools/gopls: add comma when completing the value of a key-value expression

[heschi]

If I complete an entire KV, I get the colon and comma:

_ = foo {
 <>
}

becomes

_ = foo {
  key: [value placeholder],
}

On the other hand, if I complete just the value, I have to go to the work of pressing the comma key myself:

_ = foo {
  key: <>
}

becomes

_ = foo {
  key: [value]
}

This could probably save me multiple keypresses per week.

@muirdm

[danishprakash]

While I agree with what you've described, could you point out which editor you use? I know about vim's line completion but I want to understand how you're able to complete an entire KV.

[muirdm]

how you're able to complete an entire KV

It is a gopls snippet when completing struct literal field names. You get the comma if the field name is on a different line than the open curly.

This could probably save me multiple keypresses per week.

Granted, but we need to weigh that against how many keystrokes it takes to implement the feature.

Jokes aside, I think this could work, but gopls would have to leave the cursor before the comma. If the user intends to add more to the expression it would be annoying for the cursor to jump to the far side of the comma after accepting the first completion.