Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/ed25519: TestAllocations fails with BoringCrypto or without optimizations #46134

Open
FiloSottile opened this issue May 12, 2021 · 1 comment

Comments

@FiloSottile
Copy link
Contributor

@FiloSottile FiloSottile commented May 12, 2021

--- FAIL: TestAllocations (0.02s)
    ed25519_test.go:202: expected zero allocations, got 3e+01

Testing performance profiles is brittle: it currently fails on the noopt builder, and on the dev.boringcrypto branch. Even if we skipped it on both, it would fail on go test all if run without optimizations, like Delve does.

We can make it run only on a specific builder, but I am worried that will eventually drift out of sync with builder naming and end up never running. Better than nothing, I guess.

@FiloSottile FiloSottile added this to the Go1.17 milestone May 12, 2021
@FiloSottile FiloSottile self-assigned this May 12, 2021
@mknyszek mknyszek removed this from the Go1.17 milestone Aug 18, 2021
@mknyszek mknyszek added this to the Go1.18 milestone Aug 18, 2021
@odeke-em
Copy link
Member

@odeke-em odeke-em commented Dec 20, 2021

@FiloSottile thank you for filing this issue. We haven't done anything related for this cycle Go1.18, hence I am punting the issue to Go1.19.

@odeke-em odeke-em removed this from the Go1.18 milestone Dec 20, 2021
@odeke-em odeke-em added this to the Go1.19 milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants