Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/curve25519,crypto/ed25519: avo doesn't generate go:build lines #46155

Open
FiloSottile opened this issue May 13, 2021 · 1 comment
Open
Assignees
Labels
Milestone

Comments

@FiloSottile
Copy link
Contributor

@FiloSottile FiloSottile commented May 13, 2021

Due to mmcloughlin/avo#183, the autogenerated assembly is lacking //go:build lines.

See #41184.

/cc @tklauser

@gopherbot gopherbot added this to the Unreleased milestone May 13, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented May 13, 2021

Change https://golang.org/cl/319471 mentions this issue: curve25519/internal/field: fix generator module reference to x/crypto

gopherbot pushed a commit to golang/crypto that referenced this issue May 13, 2021
The generator submodule needs a module dependency on golang.org/x/crypto
to find the type information it needs.

This removes the Comment call from CL 319469 because it does not seem to
generate the intended output. See golang/go#46155.

Fixes golang/go#46133

Change-Id: Iec21c6379d81271047ebf370a76329ed3fdac85c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/319471
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
@FiloSottile FiloSottile modified the milestones: Unreleased, Go1.17 May 13, 2021
@FiloSottile FiloSottile self-assigned this May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants