Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: errors emitted multiple times for packages with missing checksums #46160

Open
bcmills opened this issue May 13, 2021 · 3 comments
Open

cmd/go: errors emitted multiple times for packages with missing checksums #46160

bcmills opened this issue May 13, 2021 · 3 comments
Assignees
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented May 13, 2021

$ go mod edit -go=1.17

$ go list all
m.go:3:8: missing go.sum entry for module providing package golang.org/x/tools/go/packages (imported by example.com); to add:
        go get example.com

$ go mod edit -go=1.16

$ go list all
go: golang.org/x/tools@v0.1.1: missing go.sum entry; to add it:
        go mod download golang.org/x/tools
go: golang.org/x/tools@v0.1.1: missing go.sum entry; to add it:
        go mod download golang.org/x/tools

$ go1.16.4 list all
go: golang.org/x/tools@v0.1.1: missing go.sum entry; to add it:
        go mod download golang.org/x/tools

-- go.mod --
module example.com

go 1.17

require golang.org/x/tools v0.1.1
-- m.go --
package example

import _ "golang.org/x/tools/go/packages"

This is a regression introduced in Go 1.17, probably by one of my changes for #36460.

CC @jayconrod @matloob

@bcmills
Copy link
Member Author

@bcmills bcmills commented May 13, 2021

(Found while writing a regression test for #46141.)

@gopherbot
Copy link

@gopherbot gopherbot commented May 14, 2021

Change https://golang.org/cl/320172 mentions this issue: cmd/go: add tests illustrating what happens when Go 1.16 is used in a Go 1.17 main module

gopherbot pushed a commit that referenced this issue May 24, 2021
… Go 1.17 main module

For #46141
Updates #46160

Change-Id: Ib22435b8051aaf3fa74d43d3b7f2d091e67f05e2
Reviewed-on: https://go-review.googlesource.com/c/go/+/320172
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
@bcmills
Copy link
Member Author

@bcmills bcmills commented Jun 11, 2021

(Unmarking as release-blocker. Realistically, nobody is going to be confused by a duplicated message, and if this were the last bug remaining in the release we wouldn't want to hold it up.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants