Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: go-source meta tag information is not automatically updated if it changes for an existing module version #46203

Open
changkun opened this issue May 17, 2021 · 7 comments

Comments

@changkun
Copy link
Contributor

@changkun changkun commented May 17, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/golang.design/x/clipboard

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36

Screenshot

image

What did you do?

The vanity URL returned an incorrect address previously, the newly released version cannot be updated to the sum db and the document page failed to synchronize with a newly released version (0.4.6).

What did you expect to see?

All released versions are shown and can be fetched via go get

What did you see instead?

v0.4.5 and v0.4.6 are not showing on the pkgsite, and go get failed on 0.4.5

@gopherbot gopherbot added this to the Unreleased milestone May 17, 2021
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 17, 2021

https://pkg.go.dev/golang.design/x/clipboard currently shows v0.4.6 for me. Is that what you were looking for?

image

@changkun
Copy link
Contributor Author

@changkun changkun commented May 17, 2021

Interesting, but the 0.4.5 is not included (still). Here is another which does not update the repository link on the right side of the page:

https://pkg.go.dev/golang.design/x/hotkey

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 17, 2021

@julieqiu julieqiu closed this May 17, 2021
@changkun
Copy link
Contributor Author

@changkun changkun commented May 17, 2021

@julieqiu No. The problem remains exist. We have many other projects and all suffering the problem (still):

The issue indicates that the database is neither fetching the real-time vanity URL information nor updates the information regularly.

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 17, 2021

@changkun thanks for following up. You are correct that once we fetch a module version, we do not refetch that information again. Since all of the modules currently exist in our database, the source information will not be re-updated. I'll reopen this issue.

@julieqiu julieqiu changed the title x/pkgsite: vanity url is not updated x/pkgsite: source information is not automatically updated if changes for an existing module version at a vanity URL May 17, 2021
@julieqiu julieqiu reopened this May 17, 2021
@julieqiu julieqiu removed this from the Unreleased milestone May 17, 2021
@julieqiu julieqiu added this to the pkgsite/unplanned milestone May 17, 2021
@julieqiu julieqiu changed the title x/pkgsite: source information is not automatically updated if changes for an existing module version at a vanity URL x/pkgsite: source information is not automatically updated if it changes for an existing module version May 17, 2021
@changkun
Copy link
Contributor Author

@changkun changkun commented May 20, 2021

@julieqiu Thanks for reopening. It is still somehow conflicts with your interpretation. For instance, this package:

https://pkg.go.dev/golang.design/x/verbose

The last update was on Sep 16, 2020.

image

The page remains show github.com/golang-design/*/verbose on the right side.

There are many different versions in the previously mentioned packages released afterward, which means the database seems good at those moments, and the page records the correct record. However, somehow the repository information was refreshed globally.

Similar repositories remain to suffer from the issue:

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 20, 2021

There are many different versions in the previously mentioned packages released afterward, which means the database seems good at those moments, and the page records the correct record. However, somehow the repository information was refreshed globally.

We monitor the Go Module Index (https://index.golang.org/index) for new modules, and when we see a new module, we download it from https://proxy.golang.org. During our download process, we also check what the repository information is, and we store that information in our database. We do not automatically refresh this information later, which is why it will be stale if you change the repository URL that your vanity URL points to afterwards.

I manually updated the latest version for each of the links you sent me, which is why those pages are now up to date. For example, https://pkg.go.dev/golang.design/x/tgstore@v0.2.1 shows github.com/golang-design/tgstore as the repository URL. I didn't update any of the earlier versions, so https://pkg.go.dev/golang.design/x/tgstore@v0.1.0, for example, still shows github.com/golang-design/*/tgstore as the repository URL.

Hope that helps clarify things! For now, we recommend creating a new version for the remaining modules that are affected, so that the latest version on pkg.go.dev is showing the correct repository URL.

@julieqiu julieqiu changed the title x/pkgsite: source information is not automatically updated if it changes for an existing module version x/pkgsite: go-source meta tag information is not automatically updated if it changes for an existing module version Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants