Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: add Pdeathsig to SysProcAttr for FreeBSD #46258

Closed
gizahNL opened this issue May 19, 2021 · 7 comments
Closed

syscall: add Pdeathsig to SysProcAttr for FreeBSD #46258

gizahNL opened this issue May 19, 2021 · 7 comments

Comments

@gizahNL
Copy link

gizahNL commented May 19, 2021

This request is to add support for Pdeathsig on FreeBSD.

FreeBSD supports requesting a signal when the parent process dies upwards from version 11.2 according to the manpages of procctl via the procctl cmd PROC_PDEATHSIG_CTL and querying the current configured signal via PROC_PDEATHSIG_STATUS

@ianlancetaylor ianlancetaylor changed the title syscall/exec add FreeBSD Pdeathsig proposal: syscall: add Pdeathsig to SysProcAttr for FreeBSD May 19, 2021
@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) May 19, 2021
@gopherbot gopherbot added this to the Proposal milestone May 19, 2021
@ianlancetaylor
Copy link
Contributor

Just a note that on Linux SysProcAttr has a Pdeathsig field that I assume would act the same way.

@gizahNL
Copy link
Author

gizahNL commented May 19, 2021

Just a note that on Linux SysProcAttr has a Pdeathsig field that I assume would act the same way.

Correct.

@rsc rsc moved this from Incoming to Active in Proposals (old) May 19, 2021
@rsc
Copy link
Contributor

rsc commented May 19, 2021

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented May 26, 2021

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc rsc moved this from Active to Likely Accept in Proposals (old) May 26, 2021
@rsc rsc moved this from Likely Accept to Accepted in Proposals (old) Jun 2, 2021
@rsc
Copy link
Contributor

rsc commented Jun 2, 2021

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: syscall: add Pdeathsig to SysProcAttr for FreeBSD syscall: add Pdeathsig to SysProcAttr for FreeBSD Jun 2, 2021
@rsc rsc modified the milestones: Proposal, Backlog Jun 2, 2021
tklauser added a commit to tklauser/go that referenced this issue Oct 11, 2021
Fixes golang#46258

Change-Id: I63f70e67274a9df39c757243b99b12e50a9e4784
tklauser added a commit to tklauser/go that referenced this issue Oct 11, 2021
Fixes golang#46258

Change-Id: I63f70e67274a9df39c757243b99b12e50a9e4784
tklauser added a commit to tklauser/go that referenced this issue Oct 12, 2021
To allow adding fields to ProcSysAttr which are supported on FreeBSD but
not on other BSDs.

For now exec_freebsd.go is an exact copy of exec_bsd.go with adjusted
build tags and copyright year.

For golang#46258
For golang#46259

Change-Id: I7667a0cdf1ca86ef64a147b77c06db70c5f8eb90
tklauser added a commit to tklauser/go that referenced this issue Oct 12, 2021
Fixes golang#46258

Change-Id: I63f70e67274a9df39c757243b99b12e50a9e4784
@gopherbot
Copy link

Change https://golang.org/cl/355569 mentions this issue: syscall: separate ProcSysAttr and forkAndExecInChild for FreeBSD

@gopherbot
Copy link

Change https://golang.org/cl/355570 mentions this issue: syscall: add support for SysProcAttr.Pdeathsig on FreeBSD

gopherbot pushed a commit that referenced this issue Oct 14, 2021
To allow adding fields to ProcSysAttr which are supported on FreeBSD but
not on other BSDs.

For now exec_freebsd.go is an exact copy of exec_bsd.go with adjusted
build tags and copyright year.

For #46258
For #46259

Change-Id: I7667a0cdf1ca86ef64a147b77c06db70c5f8eb90
Reviewed-on: https://go-review.googlesource.com/c/go/+/355569
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

5 participants