Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/regtest: TestDeleteModule_Interdependent flakes due to orphaned file reloading #46375

Open
findleyr opened this issue May 25, 2021 · 1 comment

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented May 25, 2021

Looking at regtest failures for issue #46183, one common source of flakes in slower builders is TestDeleteModule_Interdependent in golang.org/x/tools/gopls/internal/regtest/workspace.

For example:
https://build.golang.org/log/c962f4fbb5df4c74ebe76f8aeb610eed3065f267
https://storage.googleapis.com/go-build-log/8b462d75/freebsd-amd64-12_2_e126050b.log

This test failure appears to be a race related to orphaned file reloading. All failures have a log message about reloadOrphanedFiles, but when it succeeds locally I never see this log message.

Since it is an experimental feature, we should disable this test until we understand it.

CC @stamblerre @heschi

@gopherbot gopherbot added this to the Unreleased milestone May 25, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented May 25, 2021

Change https://golang.org/cl/322649 mentions this issue: gopls/internal/regtest: skip TestDeleteModule_Interdependent

Loading

gopherbot pushed a commit to golang/tools that referenced this issue May 25, 2021
This test is flaky due to orphaned file reloading. Since it is for an
experimental feature, skip it until we understand the problem.

For golang/go#46375
Updates golang/go#46183

Change-Id: Id6b369f2b61730c8503e3532547708f7689343c3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/322649
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@suzmue suzmue removed this from the Unreleased milestone May 26, 2021
@suzmue suzmue added this to the gopls/unplanned milestone May 26, 2021
@suzmue suzmue removed this from the gopls/unplanned milestone May 26, 2021
@suzmue suzmue added this to the gopls/v0.7.0 milestone May 26, 2021
@stamblerre stamblerre removed this from the gopls/v0.7.0 milestone Jun 4, 2021
@stamblerre stamblerre added this to the gopls/v0.7.1 milestone Jun 4, 2021
@stamblerre stamblerre removed this from the gopls/v0.7.1 milestone Jul 26, 2021
@stamblerre stamblerre added this to the gopls/v0.7.2 milestone Jul 26, 2021
@stamblerre stamblerre removed this from the gopls/v0.7.2 milestone Sep 9, 2021
@stamblerre stamblerre added this to the gopls/on-deck milestone Sep 9, 2021
@stamblerre stamblerre removed this from the gopls/on-deck milestone Oct 19, 2021
@stamblerre stamblerre added this to the gopls/v0.7.4 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants