x/build/internal/sourcecache: increase download size limit to accommodate larger repositories in 2021

[dmitshur]

TryBots are failing on CL 322750 with:

reading website/212bb63fb0e7677bf1f7b9c00752b5ae51417f5b from gerrit: body over 52428800 bytes

It seems like the underlying error might be coming indirectly from Gerrit at this point. Update: It's our own limit in x/build, see comment below.

We should determine if TryBots should be able to handle a large CL (it's adding approximately 70 MB of content from x/blog repo), or otherwise improve the error message to say that a known limit is being exceeded.

CC @golang/release, @rsc.

[dmitshur]

It seems that the compressed content of that CL is a 55 MB tarball, which exceeds our limit, currently 50 MB:

const maxSize = 50 << 20 // talks repo is over 25MB; go source is 7.8MB on 2015-06-15

(Source.)

It's probably time we increase that limit.

[rsc]

Indeed. x/website is only going to get bigger over time.

[dmitshur]

I'll send a CL to double the current limit. That should last some years.

[gopherbot]

Change https://golang.org/cl/322658 mentions this issue: internal/sourcecache: double size limit for repository source

[gopherbot]

Change https://golang.org/cl/365974 mentions this issue: cmd/coordinator, internal/sourcecache: don't retry when tree too big

[gopherbot]

Change https://golang.org/cl/366135 mentions this issue: internal/sourcecache: increase x/website size limit to 200 MB

[dmitshur]

Update on 2021-11-22:

x/talks content (74 MB compressed) is being moved into x/website in CL 365135, pushing it over 100 MB. CL 366135 updates the limit for x/website (only) to be 200 MB.