Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/parser: audit error recovery for go1.17 #46403

Open
findleyr opened this issue May 26, 2021 · 0 comments
Open

go/parser: audit error recovery for go1.17 #46403

findleyr opened this issue May 26, 2021 · 0 comments

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented May 26, 2021

With all the changes to go/parser merged from dev.typeparams, at least some error recovery behavior has changed in go 1.17. For example, a[] parses to a[BadExpr] on go1.16, but just BadExpr on go1.17.

Error recovery in the parser is best-effort, but we should audit changes to ensure they are acceptable. We should probably avoid changes such as the example above that lose information.

CC @griesemer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants