Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: changes in code not highlighted in grettings-multiple-people tutorial #46416

Open
AaronWiora opened this issue May 27, 2021 · 3 comments
Open

Comments

@AaronWiora
Copy link

@AaronWiora AaronWiora commented May 27, 2021

What did you expect to see?

On the site https://golang.org/doc/tutorial/greetings-multiple-people Step 2 in the code block:

// Request greeting messages for the names.
    messages, err := greetings.Hellos(names)

I think the font color should be blue, because this part changed from "Hello" to "Hellos".

What did you see instead?

Font color is black.

@gopherbot gopherbot added this to the Unreleased milestone May 27, 2021
@AaronWiora AaronWiora changed the title x/website: x/website: Changes in code not marked with blue font color May 27, 2021
@mknyszek mknyszek changed the title x/website: Changes in code not marked with blue font color x/website: changes in code not highlighted in grettings-multiple-people tutorial May 27, 2021
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented May 27, 2021

I think this is right, unless I'm misunderstanding the tutorial.

CC @dmitshur

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented May 27, 2021

I agree, this can be improved. There's already CL 311329 that was sent earlier that should address this issue. It just needs to be reviewed.

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jun 8, 2021

As @ALTree pointed out in #46642 (comment), CL 277454 is another open CL that would fix this issue.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants