x/website: build broken since CL 322790

[bcmills]

https://build.golang.org/log/777f4be48c19e0f1f4b2ebf33996073bc16b648f:

linux-amd64 at 24e9707cbfa6b1ed6abdd4b11f9ddaf3aac5ad88 building website at 64052e727d3c16a4b177c77c4dd01b877533f549

testing in module mode; GOMOD=/workdir/gopath/src/golang.org/x/website/go.mod

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/website/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn383beaa" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.50:30157" "GO111MODULE=on" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/website

go: downloading cloud.google.com/go/datastore v1.2.0
go: downloading github.com/gomodule/redigo v2.0.0+incompatible
go: downloading golang.org/x/build v0.0.0-20210422214718-6469a76194d9
go: downloading golang.org/x/tools v0.1.1-0.20210215123931-123adc86bcb6
go: downloading golang.org/x/net v0.0.0-20201110031124-69a78807bb2b
go: downloading cloud.google.com/go v0.58.0
go: downloading github.com/yuin/goldmark v1.2.1
go: downloading github.com/golang/protobuf v1.4.3
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading google.golang.org/api v0.27.0
go: downloading google.golang.org/genproto v0.0.0-20200617032506-f1bdc9086088
go: downloading google.golang.org/grpc v1.33.2
go: downloading go.opencensus.io v0.23.0
go: downloading google.golang.org/protobuf v1.25.0
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/google/go-cmp v0.5.5
go: downloading golang.org/x/text v0.3.3
?   	golang.org/x/website	[no test files]
?   	golang.org/x/website/cmd/admingolangorg	[no test files]
ok  	golang.org/x/website/cmd/golangorg	1.586s
?   	golang.org/x/website/cmd/googlegolangorg	[no test files]
ok  	golang.org/x/website/internal/api	0.108s
ok  	golang.org/x/website/internal/dl	0.044s
?   	golang.org/x/website/internal/env	[no test files]
ok  	golang.org/x/website/internal/godoc	0.202s
ok  	golang.org/x/website/internal/history	0.026s
ok  	golang.org/x/website/internal/memcache	0.049s
ok  	golang.org/x/website/internal/pkgdoc	0.270s
?   	golang.org/x/website/internal/proxy	[no test files]
ok  	golang.org/x/website/internal/redirect	5.179s
ok  	golang.org/x/website/internal/short	0.011s
ok  	golang.org/x/website/internal/spec	0.013s
?   	golang.org/x/website/internal/texthtml	[no test files]
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/website/blog/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn383beaa" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.50:30157" "GO111MODULE=on" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/website/blog

go: downloading golang.org/x/website v0.0.0-20200611220721-d72cde69aaaf
go: downloading golang.org/x/tools v0.1.1-0.20210427153610-6397a11608ad
go: downloading github.com/yuin/goldmark v1.3.3
ok  	golang.org/x/website/blog	0.190s
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/website/go.dev/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn383beaa" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.50:30157" "GO111MODULE=on" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/website/go.dev

go: warning: "golang.org/x/website/go.dev/..." matched no packages
no packages to test
:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "golang.org/x/website/tour/..."] and env ["PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "HOSTNAME=buildlet-linux-stretch-rn383beaa" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-amd64" "GOROOT_BOOTSTRAP=/go1.4" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://10.240.0.50:30157" "GO111MODULE=on" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache"] in dir /workdir/gopath/src/golang.org/x/website/tour

go: warning: "golang.org/x/website/tour/..." matched no packages
no packages to test

It's not obvious to me whether this is a problem in the x/website repo or something to do with how cmd/coordinator identifies which modules to test.

CC @golang/release

[bcmills]

(Release blocker via #11811.)

[dmitshur]

It's not obvious to me whether this is a problem in the x/website repo or something to do with how cmd/coordinator identifies which modules to test.

To provide clarity, the build is considered to fail because coordinator runs go test {module/path}/... for each module root it finds, and the go command exits with a non-zero exit code when go test pattern matches no packages.

In this case, no packages are matched in the blog and go.dev nested modules because their go.mod file hasn't been updated to the newer module path after the move to x/website:

Details

$ cd website/blog
$ go list ./... | head -3
golang.org/x/tour
golang.org/x/tour/content
golang.org/x/tour/gotour
$ go test golang.org/x/website/tour/...
go: warning: "golang.org/x/website/tour/..." matched no packages
no packages to test
$ echo $?
1

Russ has already included a fix in a stack of CLs, I'll get to reviewing it soon.

[gopherbot]

Change https://golang.org/cl/324411 mentions this issue: go.dev: fix module path to make trybots happy

[gopherbot]

Change https://golang.org/cl/324395 mentions this issue: tour: fix go.mod module path