Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Example codes don't have horizontal scroller on mobile devices #46519

Open
ghost opened this issue Jun 2, 2021 · 7 comments
Open
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite website

Comments

@ghost
Copy link

ghost commented Jun 2, 2021

What did you expect to see?

Example codes to have horizontal scroller.

What did you see instead?

Long lines are wrapped around.

@gopherbot gopherbot added this to the Unreleased milestone Jun 2, 2021
@seankhliao
Copy link
Member

seankhliao commented Jun 2, 2021

Can you link to an example?

@ghost
Copy link
Author

ghost commented Jun 2, 2021

Can you link to an example?

https://golang.org/pkg/strings/#example_Split

@dr2chase
Copy link
Contributor

dr2chase commented Jun 2, 2021

This needs a better description; do you mean that viewing the website on a mobile device, there is no scroll (and the test does not wrap)? Can you tell me what sort of mobile device you are using, and if you can tell, the OS/browser version?

Using Chrome on an Android phone with (very) up-to-date software, I see this, which looks to me like the wrapping that you desire:
Screenshot_20210602-150209

@ghost
Copy link
Author

ghost commented Jun 2, 2021

This needs a better description; do you mean that viewing the website on a mobile device, there is no scroll (and the test does not wrap)?

Yes. Example codes don't have horizontal scroll and text are (long lines) wrapped.

Can you tell me what sort of mobile device you are using, and if you can tell, the OS/browser version?

Dev: Symphony i12
OS/Browser: Android 10 Go / Bromite 90

Using Chrome on an Android phone with (very) up-to-date software, I see this, which looks to me like the wrapping that you desire:

I see the same as you see. But I don't desire line wrapping.

@ghost
Copy link
Author

ghost commented Jun 3, 2021

I opened a PR - golang/website#56

@seankhliao seankhliao added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jun 3, 2021
@ghost
Copy link
Author

ghost commented Jun 14, 2021

@seankhliao more time to take decision? It's just two lines of change.

@seankhliao
Copy link
Member

seankhliao commented Jun 14, 2021

cc @dmitshur

@ansaba ansaba modified the milestones: Unreleased, pkgsite/unplanned Jun 15, 2022
@suzmue suzmue changed the title x/website: Example codes don't have horizontal scroller on mobile devices x/pkgsite: Example codes don't have horizontal scroller on mobile devices Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. pkgsite website
Projects
None yet
Development

No branches or pull requests

4 participants