Skip to content

x/website: install from source doesn't exist #46545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
svenwiltink opened this issue Jun 3, 2021 · 4 comments
Closed

x/website: install from source doesn't exist #46545

svenwiltink opened this issue Jun 3, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Unreleased

Comments

@svenwiltink
Copy link

https://golang.org/doc/install-source.html (linked from https://golang.org/doc/install) shows the following error:

open REDACTED: file does not exist
@gopherbot gopherbot added this to the Unreleased milestone Jun 3, 2021
@seankhliao seankhliao changed the title x/website install from source doesn't exist x/website: install from source doesn't exist Jun 3, 2021
@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 3, 2021
@bcmills bcmills added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Jun 3, 2021
@bcmills
Copy link
Contributor

bcmills commented Jun 3, 2021

CC @golang/release

@bcmills
Copy link
Contributor

bcmills commented Jun 3, 2021

(More evidence for #37047?)

@bcmills bcmills mentioned this issue Jun 3, 2021
Open
@dmitshur
Copy link
Member

dmitshur commented Jun 3, 2021 •
edited
Loading

This was missed in a recent refactor in CL 296383. We need to add a redirect from the old path at _content/doc/install-source.html:

<!--{
	"Redirect": "/doc/install/source"
}-->

#37047 is going to be more helpful for x/website now that it's going though larger refactors. CC @rsc.

@dmitshur dmitshur self-assigned this Jun 3, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/324771 mentions this issue: _content/doc: add redirect and fix links to /doc/install/source

@golang golang locked and limited conversation to collaborators Jun 3, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
_content/doc: add redirect and fix links to /doc/install/source
04e4aff 
A redirect for the old /doc/install-source.html page was missed
in CL 296383. Use .md suffix for consistency with similar pages.

Update some links to point to the new canonical URLs without
the .html extension to make them shorter and save a redirect.

Fixes golang/go#46545.

Change-Id: I117ceb42bb6f97b370808d0e27ff2eaaaa5a472e
Reviewed-on: https://go-review.googlesource.com/c/website/+/324771
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dmitshur @bcmills @svenwiltink @gopherbot @seankhliao