Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/diagnostics: frequent failures in TestFillReturnsPanic #46546

Closed
bcmills opened this issue Jun 3, 2021 · 3 comments
Closed

x/tools/gopls/internal/regtest/diagnostics: frequent failures in TestFillReturnsPanic #46546

bcmills opened this issue Jun 3, 2021 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
gopls/v0.7.1

Comments

@bcmills
Copy link
Contributor

bcmills commented Jun 3, 2021

2021-06-03T14:48:35-7ac129f/linux-ppc64le-buildlet
2021-06-02T19:45:53-384c392/linux-ppc64le-buildlet
2021-06-02T19:23:16-7922491/linux-ppc64le-buildlet
2021-06-02T18:55:23-726034e/linux-ppc64le-buildlet
2021-06-02T18:55:23-726034e/linux-ppc64le-power9osu
2021-06-02T15:04:26-7271753/linux-ppc64le-buildlet
2021-06-01T17:02:03-df07577/linux-arm64-packet
2021-05-27T19:51:27-5ab822f/linux-ppc64-buildlet
2021-05-25T21:38:43-acaf218/android-amd64-emu
2021-05-19T16:08:23-49064d2/android-amd64-emu
2021-05-19T14:12:35-a0f4b7b/linux-ppc64-buildlet
2021-05-18T18:21:53-17b3466/android-amd64-emu
2021-05-12T20:59:48-8287d5d/linux-ppc64le-buildlet
2021-05-11T17:48:41-cd1d088/linux-ppc64le-buildlet
2021-05-11T14:51:35-2db0265/freebsd-arm64-dmgk
2021-05-10T23:21:19-fa05545/linux-ppc64-buildlet
2021-05-10T21:56:33-0185c7e/freebsd-arm64-dmgk
2021-05-06T03:15:21-d1ea2c7/linux-ppc64-buildlet
2021-05-06T02:57:18-f4a4129/dragonfly-amd64-5_8
2021-05-05T21:37:16-1949673/linux-ppc64le-buildlet
2021-05-03T16:07:20-def0263/linux-ppc64le-buildlet
2021-04-27T13:49:53-7b9993c/android-386-emu
2021-04-27T04:02:17-735ed62/dragonfly-amd64-5_8
2021-04-26T20:11:56-e3dc99f/linux-ppc64-buildlet
2021-04-26T17:08:16-3f1e724/android-386-emu
2021-04-23T19:11:18-e435455/linux-ppc64le-buildlet
2021-04-23T17:35:25-f7e8e24/android-386-emu
2021-04-23T16:19:37-a8e7c0c/android-386-emu
2021-04-23T16:19:37-a8e7c0c/linux-ppc64le-power9osu
2021-04-20T19:23:16-e74674a/linux-ppc64le-buildlet
2021-04-19T19:59:27-10909d8/android-386-emu
2021-04-15T21:16:26-799b682/android-386-emu
2021-04-07T17:38:53-e78b40c/linux-ppc64le-buildlet
2021-04-06T19:05:28-c602466/dragonfly-amd64-5_8
2021-04-06T19:05:28-c602466/linux-arm64-packet
2021-04-06T13:38:10-35a9159/android-386-emu
2021-04-06T13:38:10-35a9159/freebsd-arm64-dmgk
2021-03-30T20:26:08-0deaffd/linux-ppc64-buildlet
2021-03-30T19:14:42-af36406/android-386-emu
2021-03-30T19:14:42-af36406/android-amd64-emu
2021-03-30T17:48:30-682c7e6/linux-arm64-packet
2021-03-30T03:09:04-769264c/linux-ppc64le-buildlet
2021-03-29T18:55:49-94a1942/linux-ppc64le-buildlet
2021-03-25T17:12:39-63ea654/linux-ppc64le-buildlet
2021-03-25T00:32:48-7f6d50e/android-386-emu
2021-03-24T23:51:27-09a00c1/android-386-emu
2021-03-19T17:28:02-d2e11a2/android-amd64-emu
2021-03-19T17:27:31-a14ff98/android-386-emu

CC @findleyr @stamblerre
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 3, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jun 3, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/324760 mentions this issue: gopls/internal/regtest: clean up TestFillReturnsPanic

gopherbot pushed a commit to golang/tools that referenced this issue Jun 3, 2021
@stamblerre
gopls/internal/regtest: clean up TestFillReturnsPanic
8f2cf6c 
The test doesn't necessarily need to require exactly 2 log messages, so
the match doesn't need to be so exact.

Updates golang/go#46546

Change-Id: I6ec5dee820c76c41db7b1d4bad3925fc7afe25e4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/324760
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@stamblerre stamblerre self-assigned this Jun 3, 2021
@stamblerre
Copy link
Contributor

Leaving this open until we have confirmation that these flakes no longer occur. Slowbots seemed to pass on my CL.

@stamblerre stamblerre modified the milestones: Unreleased, gopls/unplanned Jun 3, 2021
@bcmills bcmills added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jun 3, 2021
@stamblerre
Copy link
Contributor

Confirmed that the failures stopped around 06/03/2021.

@stamblerre stamblerre removed this from the gopls/unplanned milestone Jul 8, 2021
@stamblerre stamblerre added this to the gopls/v0.7.1 milestone Aug 4, 2021
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
gopls/v0.7.1
Development

No branches or pull requests
3 participants
@bcmills @stamblerre @gopherbot