Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: ICE on sorting interfaces that embed both defined and anonymous types #46556

Closed
mdempsky opened this issue Jun 3, 2021 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@mdempsky
Copy link
Member

@mdempsky mdempsky commented Jun 3, 2021

Pointed out by @danscales on golang.org/cl/324330, this test case now fails to compile because Sym.Less doesn't handle sorting A and B.

package p

type A = interface {}
type B interface {}
type C interface { A; B }
@mdempsky mdempsky self-assigned this Jun 3, 2021
@mdempsky mdempsky added this to the Go1.18 milestone Jun 3, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 3, 2021

Change https://golang.org/cl/324812 mentions this issue: [dev.typeparams] cmd/compile: allow nil Syms in Sym.Less

Loading

gopherbot pushed a commit that referenced this issue Jun 3, 2021
Allows sorting interfaces that contain embedded anonymous types.

Fixes #46556.

Change-Id: If19afa1d62432323b2e98957087867afbf3f9097
Reviewed-on: https://go-review.googlesource.com/c/go/+/324812
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
@mdempsky mdempsky closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants